Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KOPS_FEATURE_FLAGS not being unset when documentation is being generated #2642

Closed
chrislovecnm opened this issue May 26, 2017 · 1 comment
Closed

KOPS_FEATURE_FLAGS not being unset when documentation is being generated #2642

chrislovecnm opened this issue May 26, 2017 · 1 comment
Labels
area/documentation good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@chrislovecnm
Copy link
Contributor

Just as with the change here https://github.com/kubernetes/kops/blob/master/cmd/kops/gen_help_docs.go#L55

We need to unset the KOPS_FEATURE_FLAGS env variable when generating documentation. If we do not unset the feature flag we can have docs generated for new flags that are only accessible via feature flags.
@BradErz BradErz mentioned this issue Jul 16, 2017
Merged
@chrislovecnm
Copy link
Contributor Author

Closing

@rifelpet rifelpet added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed good-starter-issue labels Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/documentation good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrislovecnm @rifelpet