-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating subproperties after cluster creation is prohibited by kops cli #746
Comments
@shrugs so we are missing pieces to the runtimeConfig section upon initial creation? |
kops
clikops
cli
kops
cli
@chrislovecnm I haven't looked at the code just yet, so this may be off, but the issue seems to be that when The workaround I posted above works because we're then trying to set I may have time later in the week to checkout the code and test a fix, but I don't want to make any guarantees. |
@justinsb thoughts? |
The solution by @shrugs works, I tested because I had the same error |
We have PR inbound thay may help with this ... I am looking through issues to test against #1183 - no promises but we need to test. |
The workaround worked for me, but only after a |
I can confirm that this is no longer an issue on master, so I'm closing. In summary, after adding the additional properties (note the quotes around
you must do a forced rolling update ( |
I can say that a fresh cluster version 1.5.4 then applying these changes the masters never come back online again after the rolling-update. |
kops doesn't accept adding the
runtimeConfig
with an existing cluster because the definition inconfig
differs fromcluster.spec
(i.e., it thinks we're trying to setCloudProvider
to""
, and rejects the change).The solution to get around this is to download
config.spec
and copy over thekubeAPIServer
block over toconfig
in full (and then addruntimeConfig
).After that I believe you can rolling-update as expected (untested).
The text was updated successfully, but these errors were encountered: