Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --dry-run flag to surface configuration warnings #5181

Closed
tstromberg opened this issue Aug 22, 2019 · 5 comments · Fixed by #6256
Closed

Add --dry-run flag to surface configuration warnings #5181

tstromberg opened this issue Aug 22, 2019 · 5 comments · Fixed by #6256
Assignees
@tstromberg
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ux/embedded Embedded UX blockers

Comments

@tstromberg
Copy link
Contributor

For embedding within an API, it would be handy to have a dry run mode to surface issues a user may have with the current configuration. For example:

  • Warning if the user will need sudo permissions
  • minikube start --dry-run
  • Resource warnings (RAM, CPU)

Basically, anything that would normally cause minikube start to exit due to an invalid configuration should do so and output why - and do so quickly.
@tstromberg tstromberg added ux/embedded Embedded UX blockers priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 22, 2019
@tstromberg tstromberg changed the title Add a --dry-run mode to 'minikube start' to surface warnings Add a --dry-run mode to 'minikube start' to surface configuration warnings Aug 22, 2019
@tstromberg tstromberg changed the title Add a --dry-run mode to 'minikube start' to surface configuration warnings Add --dry-run to surface configuration warnings Aug 22, 2019
@tstromberg tstromberg changed the title Add --dry-run to surface configuration warnings Add --dry-run flag to surface configuration warnings Aug 22, 2019
@tstromberg
Copy link
Contributor Author

This is still required.

@tstromberg tstromberg added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 19, 2019
@medyagh medyagh added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 4, 2019
@medyagh
Copy link
Member

medyagh commented Nov 4, 2019

my undrestanding of this issue, it should not start any Vm or machine, but does all the checks! I would be happy to review the PR for it.

@nanikjava
Copy link
Contributor

Happy to take this on.

/assign @nanikjava

@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 9, 2019
@sharifelgamal
Copy link
Collaborator

I believe this is still needed.

@nanikjava
Copy link
Contributor

/unassign @nanikjava

@tstromberg tstromberg self-assigned this Jan 9, 2020
@tstromberg tstromberg mentioned this issue Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstromberg tstromberg

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ux/embedded Embedded UX blockers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --dry-run option to start tstromberg/minikube
4 participants
@tstromberg @nanikjava @medyagh @sharifelgamal