Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling an already disabled addon causes error #6749

Closed
blueelvis opened this issue Feb 22, 2020 · 0 comments · Fixed by #6817
Closed

Disabling an already disabled addon causes error #6749

blueelvis opened this issue Feb 22, 2020 · 0 comments · Fixed by #6817
Labels
area/addons good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@blueelvis
Copy link
Contributor

The exact command to reproduce the issue: minikube addons disable metrics-server

The full output of the command that failed:

PS C:\> minikube addons disable metrics-server --v=9 --alsologtostderr
I0222 15:51:47.666300    4544 addons.go:45] Setting metrics-server=false in profile "minikube"
I0222 15:51:47.666300    4544 addons.go:105] Setting addon metrics-server=false in "minikube"
I0222 15:51:47.666300    4544 addons.go:60] IsEnabled "metrics-server" = false (listed in config=true)
W0222 15:51:47.667306    4544 addons.go:120] addon metrics-server should already be in state false
I0222 15:51:47.668269    4544 status.go:65] Checking if "minikube" exists ...
I0222 15:51:47.671271    4544 main.go:110] libmachine: [executing ==>] : C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoProfile -NonInteractive ( Hyper-V\Get-VM minikube ).state
I0222 15:51:48.283787    4544 main.go:110] libmachine: [stdout =====>] : Running

I0222 15:51:48.283787    4544 main.go:110] libmachine: [stderr =====>] :
I0222 15:51:48.285778    4544 main.go:110] libmachine: [executing ==>] : C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoProfile -NonInteractive ( Hyper-V\Get-VM minikube ).state
I0222 15:51:48.982297    4544 main.go:110] libmachine: [stdout =====>] : Running

I0222 15:51:48.982297    4544 main.go:110] libmachine: [stderr =====>] :
I0222 15:51:48.984303    4544 main.go:110] libmachine: [executing ==>] : C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe -NoProfile -NonInteractive (( Hyper-V\Get-VM minikube ).networkadapters[0]).ipaddresses[0]
I0222 15:51:49.850286    4544 main.go:110] libmachine: [stdout =====>] : 192.168.61.189

I0222 15:51:49.850286    4544 main.go:110] libmachine: [stderr =====>] :
I0222 15:51:49.892317    4544 addons.go:198] Removing /etc/kubernetes/addons/metrics-apiservice.yaml
I0222 15:51:49.892317    4544 addons.go:198] Removing /etc/kubernetes/addons/metrics-server-deployment.yaml
I0222 15:51:49.896289    4544 addons.go:198] Removing /etc/kubernetes/addons/metrics-server-service.yaml
I0222 15:51:49.918319    4544 addons.go:214] Running: sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.17.3/kubectl delete -f /etc/kubernetes/addons/metrics-apiservice.yaml -f /etc/kubernetes/addons/metrics-server-deployment.yaml -f /etc/kubernetes/addons/metrics-server-service.yaml
I0222 15:51:49.918319    4544 ssh_runner.go:101] Run: sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.17.3/kubectl delete -f /etc/kubernetes/addons/metrics-apiservice.yaml -f /etc/kubernetes/addons/metrics-server-deployment.yaml -f /etc/kubernetes/addons/metrics-server-service.yaml
I0222 15:51:50.002860    4544 ssh_runner.go:265] ! the path "/etc/kubernetes/addons/metrics-apiservice.yaml" does not exist
I0222 15:51:50.002860    4544 ssh_runner.go:265] ! the path "/etc/kubernetes/addons/metrics-server-deployment.yaml" does not exist
I0222 15:51:50.005885    4544 ssh_runner.go:265] ! the path "/etc/kubernetes/addons/metrics-server-service.yaml" does not exist
W0222 15:51:50.010855    4544 addons.go:201] error removing /etc/kubernetes/addons/metrics-server-service.yaml; addon should still be disabled as expected
W0222 15:51:50.016886    4544 addons.go:201] error removing /etc/kubernetes/addons/metrics-server-deployment.yaml; addon should still be disabled as expected
W0222 15:51:50.021859    4544 addons.go:201] error removing /etc/kubernetes/addons/metrics-apiservice.yaml; addon should still be disabled as expected
W0222 15:51:50.022855    4544 exit.go:101] disable failed: running callbacks: [addon apply: sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.17.3/kubectl delete -f /etc/kubernetes/addons/metrics-apiservice.yaml -f /etc/kubernetes/addons/metrics-server-deployment.yaml -f /etc/kubernetes/addons/metrics-server-service.yaml: Process exited with status 1
stdout:

stderr:
the path "/etc/kubernetes/addons/metrics-apiservice.yaml" does not exist
the path "/etc/kubernetes/addons/metrics-server-deployment.yaml" does not exist
the path "/etc/kubernetes/addons/metrics-server-service.yaml" does not exist
]
*
X disable failed: running callbacks: [addon apply: sudo KUBECONFIG=/var/lib/minikube/kubeconfig /var/lib/minikube/binaries/v1.17.3/kubectl delete -f /etc/kubernetes/addons/metrics-apiservice.yaml -f /etc/kubernetes/addons/metrics-server-deployment.yaml -f /etc/kubernetes/addons/metrics-server-service.yaml: Process exited with status 1
stdout:

stderr:
the path "/etc/kubernetes/addons/metrics-apiservice.yaml" does not exist
the path "/etc/kubernetes/addons/metrics-server-deployment.yaml" does not exist
the path "/etc/kubernetes/addons/metrics-server-service.yaml" does not exist
]
*
* minikube is exiting due to an error. If the above message is not useful, open an issue:
  - https://github.com/kubernetes/minikube/issues/new/choose

The operating system version: Windows 10 Pro

I think that if the addon is already disabled, the command should just say that it is already disabled instead of throwing an error?

@medyagh medyagh added area/addons kind/bug Categorizes issue or PR as related to a bug. labels Feb 23, 2020
@priyawadhwa priyawadhwa added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants