Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubectl desc node -A to minikube logs command #7092

Closed
tstromberg opened this issue Mar 18, 2020 · 2 comments · Fixed by #7105
Closed

Add kubectl desc node -A to minikube logs command #7092

tstromberg opened this issue Mar 18, 2020 · 2 comments · Fixed by #7105
Assignees
@prasadkatti
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.9.0 March 24th

Comments

@tstromberg
Copy link
Contributor

It should probably be at the top, as it's increasingly important to solve resource limitations.
@tstromberg tstromberg added this to the v1.9.0 March 24th milestone Mar 18, 2020
@tstromberg tstromberg added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 18, 2020
@tstromberg
Copy link
Contributor Author

Doing this will require adding something around here:

minikube/pkg/minikube/logs/logs.go

Line 187 in 1c9e633

cmds[r.Name()] = r.SystemLogCmd(length)

It's probably safe to use the kubectl version installed within the VM, we just have to calculate the path to it appropriately. Here's how kubeadm generaties the right path:

minikube/pkg/minikube/bootstrapper/kubeadm/kubeadm.go

Line 522 in 1c9e633

path.Join(vmpath.GuestPersistentDir, "binaries", cfg.KubernetesConfig.KubernetesVersion, "kubectl"),

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 18, 2020
@tstromberg tstromberg changed the title Add kubectl describe node -A to minikube logs Add kubectl desc node -A to minikube logs command Mar 18, 2020
@prasadkatti
Copy link
Contributor

/assign

@prasadkatti prasadkatti mentioned this issue Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prasadkatti prasadkatti

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.9.0 March 24th
Development

Successfully merging a pull request may close this issue.

Add kubectl desc nodes to minikube logs prasadkatti/minikube
2 participants
@tstromberg @prasadkatti