-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pull-kubernetes-e2e-gce-gpu blocking #4642
Comments
/assign @krzyzacy @BenTheElder @fejta |
/cc @vishh |
cc @spiffxp |
Let's make the gpu job working on prow instead of Jenkins and we can make it always run and blocking. @BenTheElder is working towards it. |
ref #4639 for the most recent PR, I've had a job pass now and once that config is updated I expect this should work. we can probably officially migrate to prow soon but I want to see it pass more :-) |
This also works on release-1.7 and has 4 succesful runs since #4639. |
I think we can flip it to prow now to give @mindprince more signals :-) |
Awesome. Thanks guys! |
We'll watch the job for a few days (until code freeze maybe), and @mindprince you will want to propose to release team to make the job blocking (maybe join our burndown meeting next Monday?) :-) |
@jdumars FYI |
This job has been pretty well behaved, perhaps we can make it blocking after the release is done? I think we will need to propose it somewhere (the sig-testing meeting maybe?) |
Just bumped into a quota issue https://k8s-testgrid.appspot.com/kubernetes-presubmits#pull-kubernetes-e2e-gce-gpu
|
xref: #4472 for probably the best solution, though generally we should be fine via |
Adding a note: the networking quota issue has been solved for this job and the fix is being rolled out to other jobs (thanks @MrHohn !) |
/unassign @jdumars |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
The
pull-kubernetes-e2e-gce-gpu
job has been running for a while on every PR and has been reasonably non-flaky: https://k8s-gubernator.appspot.com/builds/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gce-gpuWe recently stopped running all non-blocking tests on every PR in #4640.
I would like to make the
pull-kubernetes-e2e-gce-gpu
blocking if there are no objections.The text was updated successfully, but these errors were encountered: