Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the "Reviewable" button and review access enabled for kubernetes/website #7552

Closed
heckj opened this issue Feb 27, 2018 · 7 comments
Closed
Assignees

Comments

@heckj
Copy link
Contributor

heckj commented Feb 27, 2018

Problem:

Following up on "how to contribute to Docs", there have been a few instances where people utilize Reviewable that's posted into the PRs as a means of reviewing, and then the PR gets stuck in automation - /lgtm and /approve tags don't allow it to merge, because Reviewable asserts there's outstanding discussions. It doesn't happen frequently, but in a poll on the SIG Docs channel, we aren't using it as the maintainers, and find it complicates our reviews rather than helps us. Clearing the reviews and conversation so we can marge doesn't appear to be something that repo maintainers (or at least I) can do - it apepars to require everyone who was involved in the conversation to clear it for themselves.

Proposed Solution:

Disable Reviewable to the kubernetes/website repo

@heckj heckj self-assigned this Feb 27, 2018
@heckj heckj added P2 labels Feb 27, 2018
@heckj
Copy link
Contributor Author

heckj commented Feb 27, 2018

@heckj
Copy link
Contributor Author

heckj commented Feb 27, 2018

/cc @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Feb 27, 2018

/assign
I wasn't around while this was setup and am not super clear on it, but I do have privs and incentive to disable this, so going to proceed slowly.

Disabled the reviewable webhook on this repo: https://github.com/kubernetes/website/settings/hooks/10967055

https://reviewable.kubernetes.io/repositories still shows it as connected, will try disconnecting when I've seen more +1's from those you've cc'ed

@chenopis
Copy link
Contributor

+1 +1 +1 +1 +1... 😄

@heckj
Copy link
Contributor Author

heckj commented Feb 28, 2018

up votes for disabling in slack from jared, zach and steve as well.

@spiffxp
Copy link
Member

spiffxp commented Mar 12, 2018

/close
Disabled, ref kubernetes/community#1881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants