-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the "Reviewable" button and review access enabled for kubernetes/website #7552
Comments
/cc @spiffxp |
/assign Disabled the reviewable webhook on this repo: https://github.com/kubernetes/website/settings/hooks/10967055 https://reviewable.kubernetes.io/repositories still shows it as connected, will try disconnecting when I've seen more +1's from those you've cc'ed |
+1 +1 +1 +1 +1... 😄 |
up votes for disabling in slack from jared, zach and steve as well. |
/close |
Problem:
Following up on "how to contribute to Docs", there have been a few instances where people utilize Reviewable that's posted into the PRs as a means of reviewing, and then the PR gets stuck in automation - /lgtm and /approve tags don't allow it to merge, because Reviewable asserts there's outstanding discussions. It doesn't happen frequently, but in a poll on the SIG Docs channel, we aren't using it as the maintainers, and find it complicates our reviews rather than helps us. Clearing the reviews and conversation so we can marge doesn't appear to be something that repo maintainers (or at least I) can do - it apepars to require everyone who was involved in the conversation to clear it for themselves.
Proposed Solution:
Disable Reviewable to the kubernetes/website repo
The text was updated successfully, but these errors were encountered: