Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong nginx-ingress references in the code and documentation. #180

Closed
Tarick opened this issue Oct 7, 2021 · 0 comments · Fixed by #181
Closed

Wrong nginx-ingress references in the code and documentation. #180

Tarick opened this issue Oct 7, 2021 · 0 comments · Fixed by #181
Assignees
@kylehodgetts
Labels
kind/bug

Comments

@Tarick
Copy link
Contributor

Tarick commented Oct 7, 2021

Describe the bug

Kusk supports ingress-nginx which is community ingress-nginx while in the documentation and code it is frequently referred as nginx-ingress, bringing the confusion to the users.

Expected behavior

ingress-nginx everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehodgetts kylehodgetts

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename all external references to nginx-ingress to ingress-nginx kubeshop/kusk-gen
2 participants
@Tarick @kylehodgetts