Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install detected Flutter version directly #24

Closed
spydon opened this issue Aug 14, 2024 · 6 comments · Fixed by #26
Closed

Install detected Flutter version directly #24

spydon opened this issue Aug 14, 2024 · 6 comments · Fixed by #26
Assignees
Labels
enhancement New feature or request

Comments

@spydon
Copy link

spydon commented Aug 14, 2024

An enhancement proposal that would simplify it a lot for the users of this actions is to install the set fvm flutter version directly, instead of just reading out the config.
Similarly to how asdf does it: https://github.com/asdf-vm/actions

@spydon
Copy link
Author

spydon commented Aug 14, 2024

Found another action that does this here (but with non existing docs): https://github.com/Atsumi3/actions-setup-fvm

@kuhnroyal
Copy link
Owner

Hey Lukas, great idea, never thought of it this way.
Do you think defaulting to this behavior in a new major version is fine? :)

@spydon
Copy link
Author

spydon commented Aug 19, 2024

Hey Lukas, great idea, never thought of it this way.
Do you think defaulting to this behavior in a new major version is fine? :)

For sure! That's what major versions are there for 😃

@kuhnroyal kuhnroyal added the enhancement New feature or request label Aug 20, 2024
@kuhnroyal kuhnroyal self-assigned this Aug 20, 2024
@kuhnroyal
Copy link
Owner

What are your thoughts about a new input vs separate actions?

For now I havethis.

      - uses: kuhnroyal/flutter-fvm-config-action@v2
        with:
          # The setup flag will default to true in the next major version (v3)
          setup: true

@spydon
Copy link
Author

spydon commented Aug 22, 2024

A well explained input sounds like a good idea :)

@kuhnroyal
Copy link
Owner

This is now implemented in v2.3 via an input and in v3 additionally via 2 separate sub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants