Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect method doesn't throw on connection failed #48

Closed
Shiranuit opened this issue Apr 6, 2021 · 0 comments · Fixed by #49
Closed

Connect method doesn't throw on connection failed #48

Shiranuit opened this issue Apr 6, 2021 · 0 comments · Fixed by #49
Assignees
@Shiranuit
Labels
bug Something isn't working

Comments

@Shiranuit
Copy link
Contributor

Expected Behavior

When using the Websocket protocol, if the Host address is either invalid or can't be reached
I expect the connect method of the Kuzzle class to throw an Error.

Current Behavior

For now, when the connection has failed, nothing happens and the SDK is blocked indefinitely in whatever controller action there is after the connect, because the request cannot be resolved.

Context (Environment)

SDK JVM 1.2.0
Java 8
Tested on Android 11
@Shiranuit Shiranuit added the bug Something isn't working label Apr 6, 2021
@Shiranuit Shiranuit self-assigned this Apr 7, 2021
@Shiranuit Shiranuit linked a pull request Apr 7, 2021 that will close this issue
Fix connect method not throwing on failure #49
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shiranuit Shiranuit

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix connect method not throwing on failure kuzzleio/sdk-jvm
1 participant
@Shiranuit