Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DX for Query method #64

Closed
Aschen opened this issue Feb 28, 2022 · 0 comments · Fixed by #66
Closed

Improve DX for Query method #64

Aschen opened this issue Feb 28, 2022 · 0 comments · Fixed by #66
Labels
help wanted Extra attention is needed

Comments

@Aschen
Copy link

Aschen commented Feb 28, 2022

Description

The Query method only take a HashMap which leads to very poor developer experience when having to manipulate objects.

We should provide a better way to send query:

  • allows to send a JSON string
  • use a JSON serialization library
@Aschen Aschen added the help wanted Extra attention is needed label Feb 28, 2022
@Shiranuit Shiranuit linked a pull request Feb 28, 2022 that will close this issue
Improve DX for Query method #66
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve DX for Query method kuzzleio/sdk-jvm
2 participants
@Aschen @Shiranuit