Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare backend for changes in binding flow #466

Closed
2 tasks done
derberg opened this issue Sep 4, 2018 · 4 comments
Closed
2 tasks done

Prepare backend for changes in binding flow #466

derberg opened this issue Sep 4, 2018 · 4 comments
Assignees
Labels
area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.

Comments

@derberg
Copy link

derberg commented Sep 4, 2018

Confirm these statements before you submit the issue:

  • I have searched open and closed issues for duplicates.
  • I have read the contributing guidelines.

Description

  • make sure we have query for ServiceBindingUsages and are able to fetch the following information in the context:
    • name of the usage
    • bound application/resource and its kind
    • name of service binding used by the usage
    • secret of the service binding
    • status type and message
  • make sure we have query for ServiceBindings and are able to fetch the following information in the context:
    • name of the binding
    • secret
    • status type and message
    • extra para
    • get also a total number servicebindings that failed (red) or have issue (yellow). This could also be done server side, no need to have such counter logic client side
  • make sure we can fetch not only plan's schemas.service_isntance but also schemas.service_binding
  • make sure we have mutation for ServiceBinding so we are able to create a binding, providing also custom parameters if such are provided
    • response from the server should contain the name of the newly created servicebinding
    • name generation is handled server side
  • make sure we have mutation for ServiceBindingUsage so we are able to create a binding usage
    • response from the server should contain the name of the newly created usage
    • name generation is handled server side
    • setting prefix is possible
  • make sure we can query for all resources of a given kind defined by UsageKind, in namespace context. So that we can for example get names of all available Deployments, and Functions and more, if defined. So if new UsageKind Configuration is defined, I can query for all its resources and list them. The querying will not be triggered from UI as it is now, that first you specify kind, but query will fetch all kinds and its resources at the same time.

The subscription part to enable UI to display those details using websockets is handled here #269

Reasons

  • enable UI for development
  • split of view of usages vs bindings

Attachments

Below attachments are for reference to show what details are needed in the UI

screen shot 2018-09-04 at 19 21 08

screen shot 2018-09-04 at 19 20 53

screen shot 2018-09-04 at 19 30 40

screen shot 2018-09-04 at 19 32 23

screen shot 2018-09-04 at 19 37 18

@derberg derberg added kind/feature Categorizes issue or PR as related to a new feature. area/service-management Issues or PRs related to service management labels Sep 4, 2018
@PK85 PK85 added this to the Sprint_Gopher_1 milestone Sep 18, 2018
@PK85 PK85 changed the title Prepare backed for changes in binding flow Prepare backend for changes in binding flow Sep 18, 2018
@PK85
Copy link
Contributor

PK85 commented Sep 18, 2018

about SBU and SB name generation, consider:

  • use prefix which is a service instance name
  • k8s generatedName vs docker container default naming

fetching UsageKinds and instances, consider:

  • one query vs two queries (UK and then aggregated call for instances), consult with UI team

check how get values of service binding input parameters (probably same as for service instances)

@piotrmiskiewicz
Copy link
Member

piotrmiskiewicz commented Sep 21, 2018

@piotrmiskiewicz
Copy link
Member

Both SB and SBU can have generated name (if name is not provided in the input). The generated format is: randomword-randomword

@piotrmiskiewicz
Copy link
Member

piotrmiskiewicz commented Oct 1, 2018

Needs to be done:

  1. follow up task: remove query usageKindResources (can be done after ui console changes) - created Remove deprecated usageKindResources query from ui-api #1097
  2. add displayName (invent name) in bindableResources query Improve binding resources queries in ui-api #1084
  3. Field serviceBindings/serviceBindings should be changed to serviceBindings/Items Improve binding resources queries in ui-api #1084
  4. Add extra binding params values to the serviceBinding response Improve binding resources queries in ui-api #1084

@PK85 PK85 modified the milestones: Sprint_Gopher_1, Sprint_Gopher_2 Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-management Issues or PRs related to service management kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants