Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Module Catalog] Remove the mandatory module name and version fallback #2135

Open
1 task
nesmabadr opened this issue Dec 17, 2024 · 0 comments
Open
1 task

[Module Catalog] Remove the mandatory module name and version fallback #2135

nesmabadr opened this issue Dec 17, 2024 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@nesmabadr
Copy link
Contributor

Description

We have a fallback to use the module-name label and module-version annotation if the ModuleTemplate spec.moduleName or spec.version are not set. We need to remove this fallback after the warden module has their ModuleTemplate created by the modulectl

Reasons

No response

Acceptance Criteria

  • Remove the fallback here

Feature Testing

No response

Testing approach

No response

Attachments

No response
@nesmabadr nesmabadr added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nesmabadr