refact(gateway-operator): Fix inconsistent image settings #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unner-gateway-operator chart
…lows Changes reflect the changes in values.yaml file's structure. `sed` commands are now more precise.
davidkornel
changed the title
levaitamas
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
LGTM. Thanks a lot! The CI/CD pipeline looks so much better without the whitespaces.
One minor comment: this might be not a fix, rather a feat or a refactor (src). Anyway, thanks again for doing this PR!
| sed -ri 's|^(\s*)( image: docker.io/l7mp/stunnerd:\s*.*\s*$)| image: docker.io/l7mp/stunnerd:dev|' stunner-gateway-operator/values.yaml | ||
| sed -ri 's|^(\s*)( tag\s*:\s*.*\s*$)| tag: dev|' stunner-gateway-operator/values.yaml | ||
| sed -i '/stunnerGatewayOperator:/,/pullPolicy:/ s/\(pullPolicy:\s*\).*/\1Always/' stunner-gateway-operator/values.yaml | ||
| sed -i '/dataplane:/,/pullPolicy:/ s/\(pullPolicy:\s*\).*/\1Always/' stunner-gateway-operator/values.yaml |
There was a problem hiding this comment.
Thanks! This was missing from bdaf732
davidkornel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix and improve the proposed issues in PR #31. The publish workflows had to be changed accordingly. The
sedcommands are now more precise to prevent accidental overwrites in case there are keys with the same indentation depth.I was worried this might be a breaking change; however, I don't see anything that would cause trouble with these changes.
Please check @levaitamas @rg0now