Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lr_from_k_sq Function to Handle k_sq → 0 Limit for Exponents > 3 #144

Open
E-Rum opened this issue Jan 17, 2025 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@E-Rum
Copy link
Contributor

E-Rum commented Jan 17, 2025

In #128, we decided to add a condition for background correction for now, without updating the version of the lr_from_k_sq function. Currently, this function returns 0 for every exponent when k_sq = 0. However, this behavior is incorrect since the function is actually defined for exponents > 3. Therefore, we need to update this function accordingly.

It is important to note that these values may only be defined in the limit as k_sq → 0. Thus, we must ensure this is handled correctly in Torch.

@E-Rum E-Rum added enhancement New feature or request good first issue Good for newcomers labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant