Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GridSearchTuner for speeding up #152

Open
GardevoirX opened this issue Jan 22, 2025 · 0 comments
Open

Refactor GridSearchTuner for speeding up #152

GardevoirX opened this issue Jan 22, 2025 · 0 comments

Comments

@GardevoirX
Copy link
Contributor

GardevoirX commented Jan 22, 2025

The current GridSearchTuner (though have not merged yet) is found to be slow, mainly because it searches the whole parameter space, and spends too much time on timing some overly-accurate parameter sets.

Regarding the refactoring, the idea is, we can start the search from the loosest calculation level, say (x, y). We calculate its error E(x, y), if E(x, y) > E_desired, then we move to (x + 1, y) and (x, y+1). We do this repeatedly, until we reach E(x + i, y + j) <= E_desired. By this we can find a boundary, and we only timing the parameters on this boundary, this shall save a lot of calculation time.

This algorithm requires the calculation time increases as the calculation level (x, y) increases. lr_wavelength, mesh_spacing and interpolation_nodes all look like this case. However, whether this algorithm is correct, and details about the implementation are still waiting to be discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant