Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWT lib vulnerability #1751

Closed
pedromss opened this issue Jan 8, 2021 · 2 comments
Closed

JWT lib vulnerability #1751

pedromss opened this issue Jan 8, 2021 · 2 comments

Comments

@pedromss
Copy link

pedromss commented Jan 8, 2021

Issue Description

The library used for the JWT middleware has a known vulnerability and needs to be upgraded. The next version available however is a major one and as a -preview suffix which I think makes this invalid in go.mod standards.

Refer to https://snyk.io/vuln/SNYK-GOLANG-GITHUBCOMDGRIJALVAJWTGO-596515 for details

Version/commit

v4.1.17
@pedromss
Copy link
Author

pedromss commented Jan 8, 2021

Duplicated in #1712 #1647 #1713

@pedromss pedromss closed this as completed Jan 8, 2021
@aldas
Copy link
Contributor

aldas commented Jan 8, 2021

See comment #1663 (comment)

If you have set aud checking optional and token is from authoritative source (signed with trusted key) is failure to check token aud value matches even an error - because you have made EXPLICIT rule that aud can be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aldas @pedromss