Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

The "default" site won't work on Windows (partials not included?), 3 tests failed #83

Closed
bfreis opened this issue May 19, 2013 · 4 comments

Comments

@bfreis
Copy link

bfreis commented May 19, 2013

After running punch setup site; cd site; punch s, and going to http://localhost:9009 on the browser, I get a blank page which contains only a single div, without the header or the footer.

It seems that partials aren't being included.

When running the test suite with npm test against the current commit on the master branch (bc06971), there are 3 failures:

Failures:

  1) get partials collects all partials in the given directory
   Message:
     Expected spy unknown to have been called with [ null, { partial1 : 'partial output', partial2 : 'partial output' }, Date(Tue Jul 17 2012 00:00:00 GMT-0300 (E. South America Standard Time)) ] but actual calls were [ null, {  }, null ]

[...]

  2) get partials traverse all parent directories looking for partials
   Message:
     Expected spy unknown to have been called with [ null, { partial1 : 'partial output', partial2 : 'partial output', partial3 : 'partial output' }, Date(Tue Jul 17 2012 00:00:00 GMT-0300 (E. South America Standard Time)) ] but actual calls were [ null, {  }, null ]

[...]

  3) get partials set the latest modified date of all partials as the last modified date
   Message:
     Expected spy unknown to have been called with [ null, { partial1 : 'partial output', partial2 : 'partial output' }, Date(Thu Jul 19 2012 00:00:00 GMT-0300 (E. South America Standard Time)) ] but actual calls were [ null, {  }, null ]

@vladkosarev
Copy link
Contributor

Hmm, it works on my dev machine but not on another machine. Both windows 7 64bit. Will take a look at why it's happening later.

@vladkosarev
Copy link
Contributor

Tried to see what was up and after updating everything it started working. There might be some kind of dependency issue so you might need to delete npm cache and reinstall punch.

@vladkosarev
Copy link
Contributor

#84 fixes windows specs.
punch s is what's breaking things, I will take a look at it. For now you can delete output folder and do punch g, that will give you proper index page.

@laktek
Copy link
Owner

laktek commented May 20, 2013

I have merged #84 and released 0.5.28. Can we isolate the issue of punch s on windows and try to fix that? (closing this issue for now)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants