Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests containing cairo programs use sierra directly to avoid incompatibilities in the future #1035

Open
25 tasks
FrancoGiachetta opened this issue Jan 9, 2025 · 0 comments

Comments

@FrancoGiachetta
Copy link
Contributor

FrancoGiachetta commented Jan 9, 2025

Sometimes newer versions of the compiler introduce changes in the sierra generated, which may affect the way we test libfuncs. There could be cases in which we wouldn't even test the desired libfunc due to this.

To avoid this, we should replace these cairo programs with an implementation of the in sierra. By doing this, we ensure tests will always execute the same sierra program.

Here's the list of files which need the change:

  • libfuncs/array.rs
  • libfuncs/bool.rs
  • libfuncs/bounded_int.rs
  • libfuncs/box.rs
  • libfuncs/bytes31.rs
  • libfuncs/cast.rs
  • libfuncs/circuit.rs
  • libfuncs/const.rs
  • libfuncs/ec.rs
  • libfuncs/enum.rs
  • libfuncs/felt252.rs
  • libfuncs/felt252_dict.rs
  • libfuncs/felt252_dict_entry.rs
  • libfuncs/gas.rs
  • libfuncs/ int_range.rs
  • libfuncs/nullable.rs
  • libfuncs/pedersen.rs
  • libfuncs/poseidon.rs
  • libfuncs/starknet.rs
  • libfuncs/uint256.rs
  • libfuncs/uint512.rs
  • types/array.rs
  • types/enum.rs
  • types/felt_dict.rs
  • types/nullable.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant