Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of Zend\Db\Metadata for 3.0.0 #13

Closed
weierophinney opened this issue Dec 31, 2019 · 1 comment
Closed

Refactor of Zend\Db\Metadata for 3.0.0 #13

weierophinney opened this issue Dec 31, 2019 · 1 comment

Comments

@weierophinney
Copy link
Member

This PR provides changes described in #365

A few questions came up while refactoring. Some feedback is appreciated:

  • Setter returns are inconsistent (e.g. ColumnObject and ConstraintKeyObject). Since there are fluent setters, possibility is that they are being used. Therefore I recommend to unify and make all setters fluent. If that is okay, I'll provide the changes in this scope.
  • Unsure where class constants of ConstraintKeyObject and AbstractSource are used. Currently the visibility is defined as public. If they are not needed elsewhere, private or protected might be more suitable.
  • The $table parameter of loadConstraintData() and loadConstraintReferences() in class Zend\Db\Metadata\Source\AbstractSource is unused. Version 3.0 might be a good time to remove it (causing BC). Should I include this change in this scope?

Originally posted by @arueckauer at zendframework/zend-db#369

@weierophinney
Copy link
Member Author

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself

If you are looking for an actively maintained package alternative, we recommend:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant