Explain match type reduction failures in error messages #12053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also show match type reduction failures for implicit search errors and member not found errors.
Fix expectations so that we do not see package objects anymore.
OlivierBlanvillain
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 28, 2021
I suspect that the refactoring in scala#12053 turned scala#12050's infinite loop into a stack overflow, which is easy to catch. Although this doesn't completely fix the issue (we can't guarantee that no stack-consuming loops exist), I think all the looping examples we have so far error out gracefully.
michelou
pushed a commit
to michelou/scala3
that referenced
this pull request
May 1, 2021
I suspect that the refactoring in scala#12053 turned scala#12050's infinite loop into a stack overflow, which is easy to catch. Although this doesn't completely fix the issue (we can't guarantee that no stack-consuming loops exist), I think all the looping examples we have so far error out gracefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12049
Also: Some tweaks for better printing