Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow export paths to see imports #12134

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Allow export paths to see imports #12134

merged 2 commits into from
Apr 23, 2021

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 18, 2021

This simplifies the scoping rules.

Fixes #12112

@odersky
Allow export paths to see imports
1deafbc 
This simplifies the scoping rules.

Fixes scala#12112
@odersky odersky requested a review from bishabosha April 18, 2021 11:39
bishabosha
bishabosha approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except now there is a new public method on ClassCompleter

compiler/src/dotty/tools/dotc/typer/Namer.scala Outdated Show resolved Hide resolved
@bishabosha bishabosha enabled auto-merge April 23, 2021 15:15
@bishabosha bishabosha merged commit e012734 into scala:master Apr 23, 2021
@bishabosha bishabosha deleted the fix-12112 branch April 23, 2021 16:47
@Kordyjan Kordyjan added this to the 3.0.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees

@bishabosha bishabosha

Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

export to consider imported prefixes
3 participants
@odersky @bishabosha @Kordyjan