Scaladoc/inkuire #12375
Merged
Scaladoc/inkuire #12375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
May 9, 2021
There was a problem hiding this comment.
I understand this is a proof of concept but we shouldn't merge a PR containing a ~50000 lines json file and a ~2000 lines minimized javascript file. Either these files should be generated in the build, or if that can't be done for some reason they should be downloaded from the build.
|
@smarter Ok, I meant for it to be a draft. The json will not be present in the final version. I just wanted to make sure that the scaladoc will be deployed for the pr. |
KacperFKorban
force-pushed
the
scaladoc/inkuire
branch
from
b4fd8de to
7b44b16
Compare
KacperFKorban
force-pushed
the
scaladoc/inkuire
branch
2 times, most recently
from
2a8fcb8 to
1163d6a
Compare
|
Deployed scaladoc for this PR is here. Also more up to date demos look like this: |
smarter
requested changes
Jun 30, 2021
BarkingBad
reviewed
Jul 1, 2021
pikinier20
suggested changes
Jul 1, 2021
romanowski
approved these changes
Jul 2, 2021
KacperFKorban
force-pushed
the
scaladoc/inkuire
branch
from
11b19c7 to
29afc36
Compare
BarkingBad
approved these changes
Jul 2, 2021
pikinier20
approved these changes
Jul 2, 2021
smarter
requested changes
Jul 5, 2021
This reverts commit 75289bb.
…at most once for every signature
KacperFKorban
force-pushed
the
scaladoc/inkuire
branch
from
7ea9e19 to
1718d47
Compare
smarter
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PoC Hoogle-like searches to scaladoc.
e.g.