Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no links warning setting to scaladoc #12936

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

BarkingBad
Copy link
Contributor

No description provided.

@BarkingBad BarkingBad requested a review from pikinier20 June 25, 2021 12:39
@BarkingBad BarkingBad linked an issue Jun 25, 2021 that may be closed by this pull request
Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just found one possible issue

scaladoc/src/dotty/tools/scaladoc/ScaladocSettings.scala Outdated Show resolved Hide resolved
@BarkingBad BarkingBad enabled auto-merge July 2, 2021 15:46
@BarkingBad BarkingBad merged commit 147e9ba into scala:master Jul 2, 2021
// )
report.inform(msg)

if (!summon[DocContext].args.noLinkWarnings) then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requisite "extraneous parens" reminder.

@Kordyjan Kordyjan added this to the 3.0.2 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standarize scaladoc parameters between Scala2 and Scala3
5 participants