Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve modifiers when desugaring for-comps #15403

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Preserve modifiers when desugaring for-comps #15403

merged 1 commit into from
Jun 10, 2022

Conversation

albertpchen
Copy link
Contributor

When Bind trees are copied, Modifiers are not copied along with them, causing generated vals and pattern matches to lose given modifiers.

fixes #12646

@smarter smarter requested a review from odersky June 8, 2022 16:55
odersky
odersky approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@odersky odersky merged commit 6a4c1fa into scala:main Jun 10, 2022
@bishabosha bishabosha added the release-notes Should be mentioned in the release notes label Jun 26, 2022
@Kordyjan Kordyjan added this to the 3.2.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
release-notes Should be mentioned in the release notes
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Given within for-comprehension not found
4 participants
@albertpchen @odersky @Kordyjan @bishabosha