Fix two problems related to match types as array elements #15625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The erasure of an array of matchtypes should sometimes be Object
instead of Object[]
2. Classtags of matchtypes can be created only if all alternatives
produce the same classtag.
About 1: If a matchtype with alternative types A_1, ... A_n is an array element,
it should be treated in the same way as the type ? <: A_1 | ... | A_n. It's an
_unknown_ subtype of A_1 | ... | A_n. That can cause the erasure of the underlying
array to be Object.
Fixes scala#15618
dwijnand
approved these changes
Jul 9, 2022
smarter
added
the
backport:accepted
|
@Kordyjan Should we open an issue that tracks PRs that should be backported for the next release? In theory the backport:accepted is here for that purpose, but it's easy to miss that since it applies to closed PRs. |
|
@smarter I was on vacation last two weeks. That is why there was no activity around the backports. I'm regularly checking for the PRs marked with |
|
Ok sounds good! |
Kordyjan
added a commit
that referenced
this pull request
Jul 27, 2022
Backport #15625: Fix two problems related to match types as array elements
Kordyjan
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of Object[]
produce the same classtag.
About 1: If a matchtype with alternative types A_1, ... A_n is an array element,
it should be treated in the same way as the type ? <: A_1 | ... | A_n. It's an
unknown subtype of A_1 | ... | A_n. That can cause the erasure of the underlying
array to be Object.
Fixes #15618