Fix widening logic to keep instantiation within bounds #16417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, if `Config.checkConstraintsSatisfiable` was set to `true`,
then tests/pos/cls.scala would fail on `val b1` with:
Y is constrained to be >: Matchable but attempted to instantiate it to Int | String
This happens because when `widenInferred` widens a union, it constrains the
upper-bound of the parameter being instantiated to be a subtype of that union
(`tpw <:< bound`). This is usually fine, but if `isTransparent` is true, we'll
return the original unwidened type, which is now out of bounds.
To avoid this inconsistency, the `isTransparent` check is now moved before the
subtype check that updates the bounds.
smarter
force-pushed
the
inst-in-bounds
branch
from
9be9c62 to
9e11e8b
Compare
odersky
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, if
Config.checkConstraintsSatisfiablewas set totrue, then tests/pos/cls.scala would fail onval b1with:This happens because when
widenInferredwidens a union, it constrains the upper-bound of the parameter being instantiated to be a subtype of that union (tpw <:< bound). This is usually fine, but ifisTransparentis true, we'll return the original unwidened type, which is now out of bounds.To avoid this inconsistency, the
isTransparentcheck is now moved before the subtype check that updates the bounds.