-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quoted.Liftable[BigInt]
and quoted.Liftable[BigDecimal]
to the stdlib
#6944
Add quoted.Liftable[BigInt]
and quoted.Liftable[BigDecimal]
to the stdlib
#6944
Conversation
quoted.Liftable[BigInt]
to the stdlibquoted.Liftable[BigInt]
and quoted.Liftable[BigDecimal]
to the stdlib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM
@nicolasstucki is it can be done only through string representation? Have you considered to use Conversion through the string can be inefficient for really big numbers or lead for some unexpected rounding... |
I did consider the |
5151604
to
89ad39b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.