Make indentation significant in old-style control syntax #7235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Sep 17, 2019
Indentation was significant only after new-style if-then, while-do, for-yield, for-do. This was prone to cause gotchas. We now treat indentation as significant also if the conditions or enumerators of these constructs use parens or braces.
Also: align indentation in some code
A `:` at the end of a line starting an indentation region is now allowed only if option `-Yindent-colon` is set. Rewriting to colons is also subject to that setting.
Previous edits already used new syntax. Rewriting to old syntax was done automatically.
Drop it since it is not longer supported without a special option
smarter
force-pushed
the
generalize-indent
branch
from
d88f78c to
5331caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indentation was significant only after new-style if-then, while-do, for-yield, for-do.
This was prone to cause gotchas. We now treat indentation as significant also if the
conditions or enumerators of these constructs use parens or braces.
Also: Introduce option to treat colon at eol as indentation start
A
:at the end of a line starting an indentation region is nowallowed only if option
-Yindent-colonsis set. Rewriting to colonsis also subject to that setting.