Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old syntax styles for givens #7245

Merged
merged 20 commits into from
Sep 18, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Sep 17, 2019

  • Drop delegate, given ... as, and given as an infix operator.
  • Drop DottyPredef.the

Instead of `T_given` it's now `given_T`.

Reason: we want to follow the convention that these names start with a lowercase letter.
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@nicolasstucki nicolasstucki self-assigned this Sep 18, 2019
docs/docs/reference/metaprogramming/macros-spec.md Outdated Show resolved Hide resolved
library/src/dotty/DottyPredef.scala Show resolved Hide resolved
tests/neg/i4044a.scala Outdated Show resolved Hide resolved
@nicolasstucki nicolasstucki removed their assignment Sep 18, 2019
Copy link
Contributor Author

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that should be keywordText instead of Str to get proper syntax highlighting.

Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits from @odersky LGTM

the result makes sense.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the added and removed lines look indentical?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an extra space at the end of the line. If you select it you can see it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, I can't see it when selecting the line. Also, Github highlights changes in spaces by default.

Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki marked this pull request as ready for review September 18, 2019 11:19
@nicolasstucki nicolasstucki merged commit 3da2ffc into scala:master Sep 18, 2019
@nicolasstucki nicolasstucki deleted the drop-old-given branch September 18, 2019 11:26
@milessabin
Copy link
Contributor

shapeless updated in the community build here: #7244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants