Replace AsFunction implicit class with Expr.reduce #7299
Conversation
nicolasstucki
force-pushed
the
remove-asFunction-implicit-class
branch
2 times, most recently
from
b44e0ff to
30915f0
Compare
nicolasstucki
force-pushed
the
remove-asFunction-implicit-class
branch
from
30915f0 to
57b59b3
Compare
| ```scala | ||
| AsFunction(_).apply: Expr[S => T] => (Expr[S] => Expr[T]) | ||
| Expr.reduce(_).apply: Expr[(T1, ..., Tn) => R] => ((Expr[T1], ..., Expr[Tn]) => Expr[R]) | ||
| ``` |
There was a problem hiding this comment.
Maybe call it distribute? From wikipedia:
K, Distribution Axiom: □(p → q) → (□p → □q).
There was a problem hiding this comment.
distribite is not precise, it only captures a generic property in the types. It would not describe what the method actually does.
There was a problem hiding this comment.
Also reduce itself is not a distribution, reduce(_) is the a distribution.
There was a problem hiding this comment.
I agree with @liufengyun. Reduce is counter intuitive.
There was a problem hiding this comment.
Do you have another suggestion?
There was a problem hiding this comment.
The following sentence does not read well, given the literal meaning of beta-reduction:
The
Exprcompanion object contains abetaReduceconversion that turns a tree
describing a function into a function mapping trees to trees.
library/src/scala/quoted/Expr.scala
Outdated
| import qctx.tasty._ | ||
| tg.untupled(args => qctx.tasty.internal.betaReduce(f.unseal, args.toArray.toList.map(_.asInstanceOf[QuoteContext => Expr[_]](qctx).unseal)).seal.asInstanceOf[Expr[R]]) | ||
| } | ||
| /** `Expr.reduceGiven(f)(x1, ..., xn)` is functionally the same as `'{($f)(given $x1, ..., $xn)}`, however it optimizes this call |
There was a problem hiding this comment.
A function with a given parameter list is still considered contextual so keeping the terminology Contextual is still relevant. WDYT about reduceGiven to distributeContextual?
There was a problem hiding this comment.
- I considered
Contextualbut it is a bit long (though it could be acceptable) - The operation does not do a distribution
There was a problem hiding this comment.
In partial evaluation literature reduce is usually a function for symbolic reduction expressions that returns either a value (a number or an S expression) or a reduced residual expression) according to whether the passed e is static or dynamic (Section 5.4.2 in Partial Evaluation and Automatic Code Generation).
What about callStatic or something else?
| @@ -1,6 +1,6 @@ | |||
| import scala.quoted._ | |||
|
|
|||
| def testImpl(f: Expr[(Int, Int) => Int])(given QuoteContext): Expr[Int] = f('{1}, '{2}) | |||
There was a problem hiding this comment.
Indeed, by reading this reduce confuses a lot.
This function does exactly one step of that reduction depending if the |
|
It is a nitpick because |
No description provided.