Allow normal parameters after given parameters #7317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new given syntax, we can lift the restriction that normal parameters cannot follow given parameters. This restriction was introduced because with the previous syntax this looked too awkward. The added test `given-eta` shows that eta expansion works as expected for these cases.
smarter
reviewed
Sep 25, 2019
|
|
||
| @main def Test = | ||
| given C(1) | ||
| val x = f |
There was a problem hiding this comment.
What happens with eta-expansion if a parameter in the given parameter list depends on a parameter from a previous parameter list ?
There was a problem hiding this comment.
It usually fails because it can't find the given (unless the same type happens to be implemented by a previous gjven parameter). I added a test.
|
🎉 Bravo! 🎉 |
smarter
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new given syntax, we can lift the restriction that normal
parameters cannot follow given parameters. This restriction was introduced
because with the previous syntax this looked too awkward.
The added test
given-etashows that eta expansion works as expected for these cases.