Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

score column name is confusing #947

Closed
changhiskhan opened this issue Jun 6, 2023 · 1 comment · Fixed by #1055
Closed

score column name is confusing #947

changhiskhan opened this issue Jun 6, 2023 · 1 comment · Fixed by #1055
Labels
good first issue Good for newcomers help wanted Extra attention is needed python rust Rust related tasks

Comments

@changhiskhan
Copy link
Contributor

Conventionally, score means "similarity", which means higher the better.
But Lance returns score as the distance metric function, which means lower the better.
This has resulted in multiple instances of user confusion.

@eddyxu
Copy link
Contributor

eddyxu commented Jun 6, 2023

When we decide to change the name, let's also change to name a "meta column," i.e., staring with a underscore "_distance" or something, indicating that this column does not physically exist.

@changhiskhan changhiskhan added good first issue Good for newcomers help wanted Extra attention is needed python rust Rust related tasks labels Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed python rust Rust related tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants