From fa951acb3dec0357c1407e0656ce11ced1abdb05 Mon Sep 17 00:00:00 2001 From: Daniel Chico Date: Fri, 1 Mar 2024 11:40:02 -0500 Subject: [PATCH 1/4] fix: remove detail argument from ValueError --- libs/community/langchain_community/chat_models/kinetica.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/chat_models/kinetica.py b/libs/community/langchain_community/chat_models/kinetica.py index 38c5809aca543..9362e550608c5 100644 --- a/libs/community/langchain_community/chat_models/kinetica.py +++ b/libs/community/langchain_community/chat_models/kinetica.py @@ -50,7 +50,7 @@ def to_system_str(self) -> str: lines.append("(") if not self.columns or len(self.columns) == 0: - ValueError(detail="columns list can't be null.") # type: ignore + ValueError("columns list can't be null.") columns = [] for column in self.columns: From 3f2346768f665d2d9b60e9d58eaeb40fd7a89afd Mon Sep 17 00:00:00 2001 From: Daniel Chico Date: Fri, 1 Mar 2024 11:56:31 -0500 Subject: [PATCH 2/4] fix: remove unnecessary type: ignore --- .../document_loaders/azure_blob_storage_container.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/document_loaders/azure_blob_storage_container.py b/libs/community/langchain_community/document_loaders/azure_blob_storage_container.py index 4f3bc78b442b7..25f53a3ade460 100644 --- a/libs/community/langchain_community/document_loaders/azure_blob_storage_container.py +++ b/libs/community/langchain_community/document_loaders/azure_blob_storage_container.py @@ -39,7 +39,7 @@ def load(self) -> List[Document]: loader = AzureBlobStorageFileLoader( self.conn_str, self.container, - blob.name, # type: ignore + blob.name, ) docs.extend(loader.load()) return docs From 2fd929113a0373bb1ba3044a8f922b09331177b1 Mon Sep 17 00:00:00 2001 From: Daniel Chico Date: Fri, 1 Mar 2024 12:06:28 -0500 Subject: [PATCH 3/4] fix: remove unnecessary type: ignore prepending type declaration --- .../langchain_community/document_loaders/blackboard.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/community/langchain_community/document_loaders/blackboard.py b/libs/community/langchain_community/document_loaders/blackboard.py index 873f0ab1db153..682eafb3cebc7 100644 --- a/libs/community/langchain_community/document_loaders/blackboard.py +++ b/libs/community/langchain_community/document_loaders/blackboard.py @@ -176,16 +176,16 @@ def _get_attachments(self, soup: Any) -> List[str]: from bs4 import BeautifulSoup, Tag # Get content list + content_list: BeautifulSoup content_list = soup.find("ul", {"class": "contentList"}) if content_list is None: raise ValueError("No content list found.") - content_list: BeautifulSoup # type: ignore # Get all attachments attachments = [] + attachment: Tag for attachment in content_list.find_all("ul", {"class": "attachments"}): - attachment: Tag # type: ignore + link: Tag for link in attachment.find_all("a"): - link: Tag # type: ignore href = link.get("href") # Only add if href is not None and does not start with # if href is not None and not href.startswith("#"): From 5de6adea4e78cb91089b5b43aa578801d54313f8 Mon Sep 17 00:00:00 2001 From: Daniel Chico Date: Fri, 1 Mar 2024 12:10:28 -0500 Subject: [PATCH 4/4] fix: remove unnecessary type: ignore --- .../langchain_community/document_loaders/confluence.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/community/langchain_community/document_loaders/confluence.py b/libs/community/langchain_community/document_loaders/confluence.py index 0c57f48fb23ff..ca7060a286dec 100644 --- a/libs/community/langchain_community/document_loaders/confluence.py +++ b/libs/community/langchain_community/document_loaders/confluence.py @@ -469,7 +469,7 @@ def process_page( ) if include_comments or not keep_markdown_format: try: - from bs4 import BeautifulSoup # type: ignore + from bs4 import BeautifulSoup except ImportError: raise ImportError( "`beautifulsoup4` package not found, please run "