From b2133854b442389e8fd77705497fce8f0a94bf66 Mon Sep 17 00:00:00 2001 From: Jess Archer Date: Wed, 15 Feb 2023 16:10:32 +1000 Subject: [PATCH 1/3] Improve component props --- .../resources/js/Components/ApplicationLogo.jsx | 4 ++-- .../resources/js/Components/Checkbox.jsx | 6 ++---- .../resources/js/Components/DangerButton.jsx | 9 ++++----- .../resources/js/Components/Dropdown.jsx | 8 +++----- .../resources/js/Components/InputError.jsx | 8 ++++++-- .../resources/js/Components/InputLabel.jsx | 4 ++-- .../resources/js/Components/NavLink.jsx | 8 ++++---- .../resources/js/Components/PrimaryButton.jsx | 9 ++++----- .../resources/js/Components/ResponsiveNavLink.jsx | 8 +++----- .../resources/js/Components/SecondaryButton.jsx | 8 ++++---- .../resources/js/Components/TextInput.jsx | 12 ++---------- 11 files changed, 36 insertions(+), 48 deletions(-) diff --git a/stubs/inertia-react/resources/js/Components/ApplicationLogo.jsx b/stubs/inertia-react/resources/js/Components/ApplicationLogo.jsx index 21579606d..e9f15d76c 100644 --- a/stubs/inertia-react/resources/js/Components/ApplicationLogo.jsx +++ b/stubs/inertia-react/resources/js/Components/ApplicationLogo.jsx @@ -1,6 +1,6 @@ -export default function ApplicationLogo({ className }) { +export default function ApplicationLogo(props) { return ( - + ); diff --git a/stubs/inertia-react/resources/js/Components/Checkbox.jsx b/stubs/inertia-react/resources/js/Components/Checkbox.jsx index 0a02f05f9..8cff1403a 100644 --- a/stubs/inertia-react/resources/js/Components/Checkbox.jsx +++ b/stubs/inertia-react/resources/js/Components/Checkbox.jsx @@ -1,11 +1,9 @@ -export default function Checkbox({ name, value, handleChange }) { +export default function Checkbox(props) { return (

{message}

: null; +export default function InputError({ message, className, ...props }) { + return message ? ( +

+ {message} +

+ ) : null; } diff --git a/stubs/inertia-react/resources/js/Components/InputLabel.jsx b/stubs/inertia-react/resources/js/Components/InputLabel.jsx index 833555e80..30972fe38 100644 --- a/stubs/inertia-react/resources/js/Components/InputLabel.jsx +++ b/stubs/inertia-react/resources/js/Components/InputLabel.jsx @@ -1,6 +1,6 @@ -export default function InputLabel({ forInput, value, className, children }) { +export default function InputLabel({ value, className, children, ...props }) { return ( -