Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL Grammar: compileColumnExists does not check the schema #18025

Closed
phackwer opened this issue Feb 21, 2017 · 2 comments
Closed

PostgreSQL Grammar: compileColumnExists does not check the schema #18025

phackwer opened this issue Feb 21, 2017 · 2 comments

Comments

@phackwer
Copy link
Contributor

  • Laravel Version: all
  • PHP Version: any
  • Database Driver & Version: PostgreSQL any version

Description:

The current compileColumnExists does not check the schema name for the table, giving a wrong result in cases you have two tables with the same name on different schemas and with different columns.

Steps To Reproduce:

Create tables with same name and different columns, the first one found on the information_schema with that column will always get you a true result, even when it's not.
@themsaid
Copy link
Member

@phackwer you submitted a PR earlier to fix this, am I wrong?

@fernandobandeira
Copy link
Contributor

I think the PR was to #18026, this seems a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tillkruss @themsaid @phackwer @fernandobandeira