Override request header in Http Client

[DJafari]

Laravel Version

10.12.0

PHP Version

8.2.6

Database Driver & Version

No response

Description

in some case if i want change request header, caused dupplicated and only first value passed

check reproduced code and result

Steps To Reproduce

$request = Http::withHeaders([
    'X' => 'AAA'
]);
$request->withHeaders([
    'X' => 'BBB'
]);
dd($request->getOptions());

Result :

array:4 [▼ // routes/web.php:28
  "connect_timeout" => 10
  "http_errors" => false
  "timeout" => 30
  "headers" => array:1 [▼
    "X" => array:2 [▼
      0 => "AAA"
      1 => "BBB"
    ]
  ]
]

[joelbutcher]

@DJafari is this resolved if you use arrays?

request = Http::withHeaders([
    'X' => ['AAA']
]);
$request->withHeaders([
    'X' => ['BBB']
]);

dd($request->getOptions());

[DJafari]

@joelbutcher No, for me the output is still the same.

[timacdonald]

Going to close this, as this is a feature request rather than a bug. Both the first and second values for a header are passed, which the spec supports. The consuming client would need to decide how to handle things.

The following app:

Route::get('/', function () {
    return Http::withHeaders([
        'X-Foo' => 'first',
    ])->withHeaders([
        'X-Foo' => 'second',
    ])->get(url('/dump-headers'))->body();
});

Route::get('/dump-headers', fn () => request()->headers);

Correctly merges and sends both headers. This is the browser output from that application.

Content-Length: 
Content-Type:   
Host:           play.test
User-Agent:     GuzzleHttp/7
X-Foo:          first, second

[timacdonald]

To replace a header, you may call the header function...

Edited: incorrect.

[DJafari]

@timacdonald

Method Illuminate\Http\Client\PendingRequest::header does not exist.

PendingRequest doesn't have header function to replace header

so if sending array values is valid, telescope only log first value and and it has bug

i think it's bug, if someone want sending array value, he will pass in an array from the very beginning, it's mean only if we pass header with this syntax :

Http::withHeaders([
    'X' => ['AAA']
])->withHeaders([
    'X' => ['BBB']
]);

this result is correct :

array:4 [▼ // routes/web.php:28
  "connect_timeout" => 10
  "http_errors" => false
  "timeout" => 30
  "headers" => array:1 [▼
    "X" => array:2 [▼
      0 => "AAA"
      1 => "BBB"
    ]
  ]
]

[timacdonald]

@DJafari see #47335

[timacdonald]

See also laravel/telescope#1355

[DJafari]

@timacdonald thanks!