Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcasting issue in 10.21.0 #48242

Closed
AnourValar opened this issue Aug 30, 2023 · 7 comments
Closed

Broadcasting issue in 10.21.0 #48242

AnourValar opened this issue Aug 30, 2023 · 7 comments
Labels

Comments

@AnourValar
Copy link

Laravel Version

10.21.0

PHP Version

8.2.5

Database Driver & Version

No response

Description

Broadcasting stopped working in the last version of Laravel

Steps To Reproduce

The reason - the contract in WS messages was changed:

10.21.0 // NOT WORKING
{"event":"App\Notifications\UserNotification\MyNotification","channel":"private-App.User.1","data":"..."}

10.20.0 // WORKING
{"event":"Illuminate\Notifications\Events\BroadcastNotificationCreated","channel":"private-App.User.1","data":"..."}

@crynobone
Copy link
Member

Seem to be related to #48136

@crynobone
Copy link
Member

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

@cosmastech
Copy link
Contributor

cosmastech commented Sep 2, 2023

I think the issue you're describing is that the event name has changed, right @AnourValar ?

@AnourValar
Copy link
Author

AnourValar commented Sep 3, 2023

@cosmastech , yes... exactly. Frontend side just ignores the renamed event (laravel-echo).

@crynobone
Copy link
Member

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

@driesvints
Copy link
Member

I've sent in a revert for this one: #48289

@crynobone
Copy link
Member

Hey there,

v10.21.1 with the relevant changes has been released, please try again and open up a new issue if you're still experiencing this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants