From b8c4c94f33ddc2f083d924d28771bc7576e41032 Mon Sep 17 00:00:00 2001 From: "zhixiong.zhu" Date: Thu, 22 Feb 2018 19:31:18 +0800 Subject: [PATCH] Can't get correct total record when using distinct and passing argument $columns. Eg: $builder->paginate(10, ['test.id'], 'page'); --- src/Illuminate/Database/Eloquent/Builder.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Illuminate/Database/Eloquent/Builder.php b/src/Illuminate/Database/Eloquent/Builder.php index dbcd693422c5..778005caf460 100755 --- a/src/Illuminate/Database/Eloquent/Builder.php +++ b/src/Illuminate/Database/Eloquent/Builder.php @@ -705,7 +705,7 @@ public function paginate($perPage = null, $columns = ['*'], $pageName = 'page', $perPage = $perPage ?: $this->model->getPerPage(); - $results = ($total = $this->toBase()->getCountForPagination()) + $results = ($total = $this->toBase()->getCountForPagination($columns)) ? $this->forPage($page, $perPage)->get($columns) : $this->model->newCollection();