-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with @vite/plugin-legacy #114
Comments
vilbergs
changed the title
Compatability with @vite/plugin-legacy
Compatibility with @vite/plugin-legacy
Aug 3, 2022
Right now, we don't aim to be compatible with this library, sorry. |
For reference, @kitro suggested a workaround here: laravel/framework#42785 (comment) |
Is this still true that the vite-plugin will not be compatible with the legacy plugin? Seems weird to not support older browsers out of the box. |
hi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
I've had fantastic success using this plugin so far, thanks for making our migration to Vite a breeze.
I've been trying to get @vite/plugin-legacy to work alongside this plugin, but the automatic code injection does not seem to take effect, I'm assuming that is for similar reasons that the legacy plugin does not work with the
lib
entry options in the Vite config (see vitejs/vite#1639).So far I've gotten Safari 11 to work by manually including the "polyfills" chunk generated by the build, but in order to support Edge 18 I believe I need the runtime check for dynamic import support to run.
Any help towards a solution would be deeply appreciated, if this plugin uses the
lib
option for entry points I assume we'll just have to hope that vitejs/vite#1639 gets solved, but until then I'll explore workarounds.The text was updated successfully, but these errors were encountered: