From 1c6156b889d295068d4a0e20b236250a973c023b Mon Sep 17 00:00:00 2001 From: Lars Willighagen Date: Thu, 16 Aug 2018 00:39:37 +0200 Subject: [PATCH] fix(parseable): add support for more resolves on update/install action Add support for multiple resolves on the same update/install action. Re comment: it seems not to be true. See https://npm.community/t/1419 --- reporters/parseable.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/reporters/parseable.js b/reporters/parseable.js index 4a0dd01..eedad7f 100644 --- a/reporters/parseable.js +++ b/reporters/parseable.js @@ -26,16 +26,18 @@ const report = function (data, options) { l.recommendation = recommendation.cmd l.breaking = recommendation.isBreaking ? 'Y' : 'N' - // TODO: Verify: The advisory seems to repeat and be the same for all the 'resolves'. Is it true? - const advisory = data.advisories[action.resolves[0].id] - l.sevLevel = advisory.severity - l.severity = advisory.title - l.package = advisory.module_name - l.moreInfo = `https://nodesecurity.io/advisories/${advisory.id}` - l.path = action.resolves[0].path - - accumulator[advisory.severity] += [action.action, l.package, l.sevLevel, l.recommendation, l.severity, l.moreInfo, l.path, l.breaking] + action.resolves.forEach((resolution) => { + const advisory = data.advisories[resolution.id] + + l.sevLevel = advisory.severity + l.severity = advisory.title + l.package = advisory.module_name + l.moreInfo = `https://nodesecurity.io/advisories/${advisory.id}` + l.path = resolution.path + + accumulator[advisory.severity] += [action.action, l.package, l.sevLevel, l.recommendation, l.severity, l.moreInfo, l.path, l.breaking] .join('\t') + '\n' + }) // forEach resolves } if (action.action === 'review') {