Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-ASCII chars in MySQL and MSSQL credentials #650

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Support non-ASCII chars in MySQL and MSSQL credentials #650

merged 3 commits into from
Nov 12, 2020

Conversation

yerke
Copy link
Contributor

@yerke yerke commented Aug 23, 2020 •
edited
Loading

Properly support non-ASCII chars in MySQL and MSSQL credentials (username and password).
Based on how postgres part does the same: #630
Closes #597

@yerke yerke changed the title Support non-ASCII chars in mysql credentials Support non-ASCII chars in MySQL and MSSQL credentials Aug 23, 2020
@yerke
Copy link
Contributor Author

yerke commented Aug 24, 2020

CI failed for unrelated reason:

/Users/runner/.cargo/bin/cargo build --manifest-path sqlx-cli/Cargo.toml --bin cargo-sqlx
   Compiling sqlx-rt v0.1.1 (/Users/runner/work/sqlx/sqlx/sqlx-rt)
error[E0463]: can't find crate for `pin_project_internal` which `async_std` depends on
##[error]  --> sqlx-rt/src/lib.rs:91:9
   |
91 | pub use async_std::{
   |         ^^^^^^^^^ can't find crate

error: aborting due to previous error

@abonander
Copy link
Collaborator

@yerke can you please rebase? CI should be fixed afterwards

@yerke
Copy link
Contributor Author

yerke commented Nov 5, 2020

@abonander Done. I tried to keep the changes consistent with #630, and it meant keeping my changes rather than what we have in master branch.

@mehcode mehcode merged commit b8bce0a into launchbadge:master Nov 12, 2020
@yerke yerke deleted the mysql-non-ascii-credentials branch November 13, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug db:mssql db:mysql Related to MySQL needs rebase waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugs about URL and percent-encoded ASCII string
4 participants
@yerke @abonander @mehcode @izik1