fix: space above pagination dots and pagination bug #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyguduru
commented
Apr 9, 2024
| @@ -40,7 +40,6 @@ func NewChooseSDKModel(selectedIndex int) tea.Model { | |||
| l.SetShowPagination(true) | |||
| l.SetShowStatusBar(false) | |||
| l.SetFilteringEnabled(false) // TODO: try to get filtering working | |||
| l.Paginator.PerPage = 5 | |||
There was a problem hiding this comment.
We're not allowed to manually set this unfortunately. The property gets computed automatically by list.updatePagination(). So setting it manually messes up the computation. I found a way to show exactly 5 items or less on every page though by setting the hight on line 34 to 9.
sunnyguduru
changed the title
dbolson
approved these changes
Apr 9, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the extra space between the choose sdk list and the pagination dots.
bug fix: we were only showing 15 items total. This was due to setting pagination.PerPage manually to 5. We can't manually control this property without bugs due to how list.updatePagination() works. Setting the list height to 9 shows us 5 items, and displays all 24-25 items.
video: https://share.cleanshot.com/bs9YgdBF