fix: fix go sdk instructions #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k3llymariee
commented
May 8, 2024
| ```shell | ||
| go get github.com/launchdarkly/go-server-sdk/v6 | ||
| go get github.com/launchdarkly/go-server-sdk/v7 |
There was a problem hiding this comment.
the file itself imports v7 below
internal/sdks/sdk_instructions/go.md
Outdated
| @@ -99,9 +99,10 @@ func main() { | |||
|
|
|||
| Now that your application is ready, run the application to see what value we get. | |||
| ```shell | |||
| export LAUNCHDARKLY_SDK_KEY=1234567890abcdef | |||
There was a problem hiding this comment.
the file gets the environment variable but we didn't actually set it anywhere. this could probably go at the top or here, doesn't matter much where
| go build && ./hello-go | ||
| ``` | ||
|
|
||
| You should see: | ||
|
|
||
| `Feature flag my-flag-key is FALSE for this context` | ||
| `*** The 'my-flag-key' feature flag evaluates to false.` |
There was a problem hiding this comment.
this is actually what the logs say
dbolson
approved these changes
May 8, 2024
There was a problem hiding this comment.
Looks like I missed these changes since they're already in the quickstart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tried actually setting these up for the next demo day recording and noticed these were off. will let the quickstart team know also