Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim fields allowing incorrect timestamps #1177

Closed
2 tasks done
jscdev909 opened this issue Aug 4, 2024 · 0 comments · Fixed by #1184
Closed
2 tasks done

Trim fields allowing incorrect timestamps #1177

jscdev909 opened this issue Aug 4, 2024 · 0 comments · Fixed by #1184
Labels
bug Something isn't working

Comments

@jscdev909
Copy link

Checklist

Edition

Windows GUI Application

Describe your issue here

The trim fields in the "VOD Download", "Chat Download", and "Chat Updater" modes are allowing incorrect timestamps such as 1:60:60 to be entered. This applies for both the "Start" and "End" timestamp fields. If a download or update is queued with any incorrect timestamp the program seems to convert the timestamp to a correct one (for example: 1:60:60 is interpreted to mean 2:01:00) as long as the corrected timestamp is within the VOD/chat length.

I would like to propose that such selections shouldn't be allowed at all and that the maximum value for the trim minutes and seconds fields should be capped at 59 instead of 60. This would avoid confusion and be more consistent with the way Twitch handles timestamps.

Screenshot 2024-08-04 104031

Add any related files or extra information here

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant