Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrible performance compared to previous versions. Crashes #18

Closed
tolekk opened this issue Feb 16, 2020 · 7 comments
Closed

Terrible performance compared to previous versions. Crashes #18

tolekk opened this issue Feb 16, 2020 · 7 comments

Comments

@tolekk
Copy link

tolekk commented Feb 16, 2020

As in the title, the newest version of the tool completely dunked on its performance in my system for some reason. I have a Ryzen 7 2700X and before, 6h chats would render in about 4 hours, but now it takes 12. I noticed the tool only uses 1 core of my CPU for the rendering and a little bit of my GPU for some reason. Tried using -threads 16 arguments in FFmpeg options in the tool but to no effect.
There also were crashes when rendering, but only about 2-3 hours into it. Testing another render now, we'll see what error it gives, but it had something to do with "pipe" - I can't remember more.

Below I attached my render settings. Crashes happened on MP4 H264, so I'm testing MOV right now.

image

EDIT: UPDATE. left the rendering to itself and went to get groceries. Also noticed the program runs in 32bit mode.
image

image
I wonder if this issue is only specific to my setup. If you have or don't have this issue on version 1.2 please mention it.

@lay295
Copy link
Owner

lay295 commented Feb 16, 2020

I probably made some bad change proformance wise for larger chats, when I do testing I usually stay with the default small chatbox, and maybe double the size. I checked and the proformance for me is slightly worse than the older one for rendering a 1 hour video (14 min compared to old one at 13min).

I'll try with your settings later when I have time and compare performance and see where's it going wrong and needs fixing. I'd suggest using the older version for now.

Whoops didn't mean to close.

@lay295 lay295 closed this as completed Feb 16, 2020
@lay295 lay295 reopened this Feb 16, 2020
@tolekk
Copy link
Author

tolekk commented Feb 16, 2020

Yeah the reason for the resolution in my case is that keying looks way better this way. I don't want to use outlines for my videos so lower resolution messes with the font. Hope you can find out what's causing this. 👌

@lay295
Copy link
Owner

lay295 commented Feb 18, 2020

I found the issue and it should render at the same speed as the previous version. Using your settings I wasn't able to render at the speeds you were claiming, but for me it is rendering at the same speed as the previous version.

I'm really unsure about the crashes, it could have been because it was compiled as 32-bit which can only use 2-4GB of ram. So hopefully building it as 64-bit won't have it crash. So give the new version a shot.

If renders are too long, you can try giving 30 fps a try instead of 60. It'll look practically the same and cut the time in half. If you also have a lot of free hard drive space you can try encoding at a smaller resolution with a transparent background with MOV + RLE and you won't have to chroma key anything out because the background will be transparent.

image
For example, I'm not a video editor but I can use these settings and it renders at 15x real time speed, so 1 hour takes about 4 minutes. It produces about a 2.5GB file though, and even though it's smaller resolution at 30fps the results look pretty good.
https://youtu.be/CoOdP--vLqM

@tolekk
Copy link
Author

tolekk commented Feb 18, 2020

Great! The performance is way better thanks to the 64-bit build. There is still lots of optimizing to be done with ffmpeg but for now this is amazing.
The update introduced a small bug tho. The grey/black names disappear on the background we used up to this point, it's not an issue for black/transparent background.
image

@lay295
Copy link
Owner

lay295 commented Feb 18, 2020

Hmmm not sure, I forgot to return a value with names but I don't know if that's the reason.

You can re-download 1.21 with the small fix and can give that a try and see if it still happens. If it still happens can you give me the RGBA value for your background?

@lay295
Copy link
Owner

lay295 commented Feb 22, 2020

Hey, still having the name issue? Can't seem to reproduce it.
If you could share a .json with the issue and your settings I'd appreciate it.

@tolekk
Copy link
Author

tolekk commented Feb 24, 2020

Sorry for the late response. It seems like the names are the same colour as the background, making them invisible after keying.

@ScrubN ScrubN closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants