Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialization error (JSON value could not be converted to System.Int32) #759

Closed
2 tasks done
VisualRedux opened this issue Jul 24, 2023 · 5 comments · Fixed by #843
Closed
2 tasks done

Deserialization error (JSON value could not be converted to System.Int32) #759

VisualRedux opened this issue Jul 24, 2023 · 5 comments · Fixed by #843
Labels
bug Something isn't working

Comments

@VisualRedux
Copy link

VisualRedux commented Jul 24, 2023

Checklist

Edition

Windows GUI Application

Describe your issue here

When trying to render out the chat (only for a few older vods) I keep getting this error:
ERROR: The JSON value could not be converted to System.Int32. Path: $.id | LineNumber: 0 | BytePositionInLine: 36.

I tried the chat updater but it instantly crashes the application.
Any help is greatly appreciated!

Add any related files or extra information here

Here is a link to the json file: https://drive.google.com/file/d/1LNtvJDXowB3J_YaxwkmSvrVQF91LYVkx/view

@VisualRedux VisualRedux added the bug Something isn't working label Jul 24, 2023
@VisualRedux
Copy link
Author

Just figured out a fix! Just needed to remove the quotes around the id number.
For example, it was:
{"streamer":{"name":"sodapoppin","id":"26301881"}

And I changed it to:
{"streamer":{"name":"sodapoppin","id":26301881}

dont know anything about this stuff so im pretty hyped that I figured it out haha

@ScrubN
Copy link
Collaborator

ScrubN commented Jul 24, 2023

Was the json file created by an older version of TwitchDownloader? If so, this could be a problem for other users too.

@LCSQ
Copy link

LCSQ commented Oct 6, 2023

thanks, this solved my issue. It is a problem with json files generated by old TwitchDownloader. It should be noted in common errors.

@ScrubN
Copy link
Collaborator

ScrubN commented Oct 7, 2023

It should be noted in common errors.

The user should not be expected to modify their json files. I will implement a fix in the deserializer.

@ScrubN ScrubN reopened this Oct 7, 2023
@ScrubN ScrubN changed the title Chat render error (JSON value could not be converted to System.Int32) Deserialization error (JSON value could not be converted to System.Int32) Oct 7, 2023
@ScrubN
Copy link
Collaborator

ScrubN commented Oct 7, 2023

Until the next version is released, you may use this workflow build to avoid any future errors with old chats: https://github.com/lay295/TwitchDownloader/actions/runs/6438276408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants