When replacestream is used replace function is passed array of matches

[nlundquist]

As per the replacestream docs (https://github.com/eugeneware/replacestream) the replacement function is passed an array of matches rather than being called with the matches as parameters, the behaviour of String.replace.

Gulp-replace implies in its documentation that the String.replace behaviour should be expected despite this being false when replacestream is used. This can't be expected by the user. When using replacestream gulp-replace should wrap the replacement function so that the array is converted into parameters for the wrapped function.

[mehtaphysical]

Maybe this is something i should change with replacestream. I think it is easier if everything is consistent with String.replace

[lazd]

Hmm, I agree we should definitely be consistent between a regex match on a stream and on a buffer.

@mehtaphysical @eugeneware, what do you think?

[mehtaphysical]

I'm willing to make that change. I wonder what @eugeneware thinks. I created an issue eugeneware/replacestream#15

[eugeneware]

It's ok by me. Consistency and ease of use should trump compatibility. 👍

[lazd]

@eugeneware @mehtaphysical any timeline on getting this made consistent? I'm thinking a temporary workaround as suggested by @nlundquist is in order until it's changed in replacestream.

[mehtaphysical]

@lazd it's a pretty easy change. I'll write it this weekend and let @eugeneware review it.

[lazd]

Sounds great, thanks!

[eugeneware]

Sounds like a plan! :-)

[mehtaphysical]

@lazd done :)

[lazd]

Released as [email protected].