Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BoilerPlant.Submodels.BoilerPlantControls.SetPoints.MinimumFlowSetPoint #122

Open
mwetter opened this issue May 16, 2022 · 2 comments

Comments

@mwetter
Copy link
Member

mwetter commented May 16, 2022

The controller BoilerPlant.Submodels.BoilerPlantControls.SetPoints.MinimumFlowSetPoint uses the following construct:

image

This can likely be done more efficient (and clearer) with a switch or a maybe a switch and a pre block. The current implementation integrates 0 and adds the reset value, which seems overly complex.

@karthikeyad-pnnl: Can you please refactor it and make a PR. This is from commit 0e00d31, branch issue92_caseStudyFullHVAC

@karthikeyad-pnnl
Copy link

@mwetter : I will look into the suggested alternatives. I know that the Modelica language has an in-built pre function, but do we have a CDL implementation of the pre block for Real variables? Or do we only have it for Boolean variables?

@mwetter
Copy link
Member Author

mwetter commented May 18, 2022

In CDL, we only have Logical.Pre. We didn't expect to need it for Real (and Integer), but maybe we do need it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants