You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The controller BoilerPlant.Submodels.BoilerPlantControls.SetPoints.MinimumFlowSetPoint uses the following construct:
This can likely be done more efficient (and clearer) with a switch or a maybe a switch and a pre block. The current implementation integrates 0 and adds the reset value, which seems overly complex.
@karthikeyad-pnnl: Can you please refactor it and make a PR. This is from commit 0e00d31, branch issue92_caseStudyFullHVAC
The text was updated successfully, but these errors were encountered:
@mwetter : I will look into the suggested alternatives. I know that the Modelica language has an in-built pre function, but do we have a CDL implementation of the pre block for Real variables? Or do we only have it for Boolean variables?
The controller
BoilerPlant.Submodels.BoilerPlantControls.SetPoints.MinimumFlowSetPoint
uses the following construct:This can likely be done more efficient (and clearer) with a switch or a maybe a switch and a pre block. The current implementation integrates 0 and adds the reset value, which seems overly complex.
@karthikeyad-pnnl: Can you please refactor it and make a PR. This is from commit 0e00d31, branch
issue92_caseStudyFullHVAC
The text was updated successfully, but these errors were encountered: