Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure renderer's container is init'ed when a path is added to map #5404

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Ensure renderer's container is init'ed when a path is added to map #5404

merged 1 commit into from
Mar 29, 2017

Conversation

IvanSanchez
Copy link
Member

Fixes #5401. Calling the renderer's _initContainer() before the renderer is added to the map has no ill effects.

Haven't tried with a Canvas renderer, but I expect no problems, as the DOM is not involved in that case.

@IvanSanchez IvanSanchez added this to the 1.1 milestone Mar 22, 2017
perliedman
perliedman reviewed Mar 22, 2017
View reviewed changes
Copy link
Member

@perliedman perliedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we could easily unit test?

The change in itself looks obvious, just thinking of adding guards against future problems as we find them

@perliedman perliedman merged commit 28a0adc into master Mar 29, 2017
@mourner mourner deleted the delayed-paths branch March 20, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perliedman perliedman perliedman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanSanchez @perliedman